From: Nícolas F. R. A. Prado Date: Tue, 5 Mar 2024 22:21:36 +0000 (-0500) Subject: driver: core: Log probe failure as error and with device metadata X-Git-Tag: v6.9-rc1~34^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=32de4b4f9dfa67917d2cc824a195498513ec8e8d;p=linux-block.git driver: core: Log probe failure as error and with device metadata Drivers can return -ENODEV or -ENXIO from their probe to reject a device match, and return -EPROBE_DEFER if probe should be retried. Any other error code is not expected during normal behavior and indicates an issue occurred, so it should be logged at the error level. Also make use of the device variant, dev_err(), so that the device metadata is attached to the log message. Signed-off-by: "Nícolas F. R. A. Prado" Link: https://lore.kernel.org/r/20240305-device-probe-error-v1-1-a06d8722bf19@collabora.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 85152537dbf1..0b7cf4516796 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -592,8 +592,8 @@ static int call_driver_probe(struct device *dev, struct device_driver *drv) break; default: /* driver matched but the probe failed */ - pr_warn("%s: probe of %s failed with error %d\n", - drv->name, dev_name(dev), ret); + dev_err(dev, "probe with driver %s failed with error %d\n", + drv->name, ret); break; }