From: Yang Yingliang Date: Thu, 15 Sep 2022 11:42:10 +0000 (+0800) Subject: net: ethernet: ti: cpsw_new: Switch to use dev_err_probe() helper X-Git-Tag: block-6.1-2022-13-10~73^2~151^2~4 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=2c22e42edc8d18092a5ed7b77ab1a2996948a0ee;p=linux-block.git net: ethernet: ti: cpsw_new: Switch to use dev_err_probe() helper dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c index 007de15179f0..14fd90da32fd 100644 --- a/drivers/net/ethernet/ti/cpsw_new.c +++ b/drivers/net/ethernet/ti/cpsw_new.c @@ -1288,9 +1288,8 @@ static int cpsw_probe_dt(struct cpsw_common *cpsw) if (of_phy_is_fixed_link(port_np)) { ret = of_phy_register_fixed_link(port_np); if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "%pOF failed to register fixed-link phy: %d\n", - port_np, ret); + dev_err_probe(dev, ret, "%pOF failed to register fixed-link phy\n", + port_np); goto err_node_put; } slave_data->phy_node = of_node_get(port_np);