From: Oleg Nesterov <oleg@redhat.com>
Date: Mon, 10 May 2021 16:15:22 +0000 (+0200)
Subject: sched/core: Remove the pointless BUG_ON(!task) from wake_up_q()
X-Git-Tag: block-5.14-2021-07-08~85^2~73
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=2b8ca1a907d5fffc85fb648bbace28ddf3420825;p=linux-block.git

sched/core: Remove the pointless BUG_ON(!task) from wake_up_q()

container_of() can never return NULL - so don't check for it pointlessly.

[ mingo: Twiddled the changelog. ]

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210510161522.GA32644@redhat.com
---

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5226cc26a095..61d1d85bb93d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -585,7 +585,6 @@ void wake_up_q(struct wake_q_head *head)
 		struct task_struct *task;
 
 		task = container_of(node, struct task_struct, wake_q);
-		BUG_ON(!task);
 		/* Task can safely be re-inserted now: */
 		node = node->next;
 		task->wake_q.next = NULL;