From: Saravana Kannan Date: Thu, 24 Oct 2024 06:13:44 +0000 (-0700) Subject: drivers: core: fw_devlink: Make the error message a bit more useful X-Git-Tag: v6.13-rc1~29^2~11 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=298c2af4788ed027a42c2bab0f210219825fb5fd;p=linux-block.git drivers: core: fw_devlink: Make the error message a bit more useful It would make it easier to debugs issues similar to the ones reported[1][2] recently where some devices didn't have the fwnode set. [1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ [2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Signed-off-by: Saravana Kannan Link: https://lore.kernel.org/r/20241024061347.1771063-4-saravanak@google.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/core.c b/drivers/base/core.c index 633fb4283282..3a870662bb6c 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2173,8 +2173,8 @@ static int fw_devlink_create_devlink(struct device *con, } if (con != sup_dev && !device_link_add(con, sup_dev, flags)) { - dev_err(con, "Failed to create device link (0x%x) with %s\n", - flags, dev_name(sup_dev)); + dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n", + flags, dev_name(sup_dev), link->consumer); ret = -EINVAL; }