From: Jiapeng Chong Date: Wed, 2 Jun 2021 10:05:48 +0000 (+0800) Subject: platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard() X-Git-Tag: block-5.14-2021-07-08~39^2~53 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=28e367127718a9cb85d615a71e152f7acee41bfc;p=linux-2.6-block.git platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard() The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'error'. Eliminate the follow smatch warning: drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard() warn: missing error code 'error'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index fa7232ad8c39..352508d30467 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -2831,6 +2831,7 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev) if (!dev->info_supported && !dev->system_event_supported) { pr_warn("No hotkey query interface found\n"); + error = -EINVAL; goto err_remove_filter; }