From: Armin Wolf Date: Wed, 28 Jul 2021 22:15:57 +0000 (+0200) Subject: hwmon: (dell-smm-hwmon) Fix fan mutliplier detection for 3rd fan X-Git-Tag: libata-5.15-2021-09-05~57^2~22 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=2757269a7defe96e871be795b680b602efb877ce;p=linux-block.git hwmon: (dell-smm-hwmon) Fix fan mutliplier detection for 3rd fan There are up to three fans, but the detection omits the 3rd one. Fix that by using DELL_SMM_NO_FANS. Signed-off-by: Armin Wolf Fixes: 747bc8b063ae (hwmon: (dell-smm) Detect fan with index=2) Link: https://lore.kernel.org/r/20210728221557.8891-7-W_Armin@gmx.de Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index aaf864dbe53a..206418405440 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1263,7 +1263,7 @@ static int __init dell_smm_probe(struct platform_device *pdev) * Autodetect fan multiplier based on nominal rpm * If fan reports rpm value too high then set multiplier to 1 */ - for (fan = 0; fan < 2; ++fan) { + for (fan = 0; fan < DELL_SMM_NO_FANS; ++fan) { ret = i8k_get_fan_nominal_speed(data, fan, data->i8k_fan_max); if (ret < 0) continue;