From: Nick Desaulniers Date: Tue, 19 Sep 2023 20:38:31 +0000 (-0700) Subject: bcachefs: Fix -Wself-assign X-Git-Tag: io_uring-6.7-2023-11-10~119^2~50 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=265cc423155d56030e44068680085adb59800326;p=linux-block.git bcachefs: Fix -Wself-assign Fixes the following observed error reported by Nathan on IRC. fs/bcachefs/io_misc.c:467:6: error: explicitly assigning value of variable of type 'int' to itself [-Werror,-Wself-assign] 467 | ret = ret; | ~~~ ^ ~~~ Reported-by: Nathan Chancellor Signed-off-by: Nick Desaulniers Signed-off-by: Kent Overstreet --- diff --git a/fs/bcachefs/io_misc.c b/fs/bcachefs/io_misc.c index 668493bcfe36..32432bdddac4 100644 --- a/fs/bcachefs/io_misc.c +++ b/fs/bcachefs/io_misc.c @@ -462,9 +462,9 @@ btree_err: bch2_logged_op_update(trans, &op->k_i)); } - fallthrough; + break; case LOGGED_OP_FINSERT_finish: - ret = ret; + break; } err: bch2_logged_op_finish(trans, op_k);