From: Chen Ni <nichen@iscas.ac.cn>
Date: Thu, 10 Apr 2025 07:56:35 +0000 (+0800)
Subject: tee: optee: smc: remove unnecessary NULL check before release_firmware()
X-Git-Tag: v6.16-rc1~100^2~17^2~1
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=26104d81567376b2038c4f52c90d849ee32639a9;p=linux-block.git

tee: optee: smc: remove unnecessary NULL check before release_firmware()

release_firmware() checks for NULL pointers internally.
Remove unneeded NULL check for fmw here.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
---

diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c
index f0c3ac1103bb..26f8f7bbbe56 100644
--- a/drivers/tee/optee/smc_abi.c
+++ b/drivers/tee/optee/smc_abi.c
@@ -1551,8 +1551,7 @@ fw_load:
 		  data_pa_high, data_pa_low, 0, 0, 0, &res);
 	if (!rc)
 		rc = res.a0;
-	if (fw)
-		release_firmware(fw);
+	release_firmware(fw);
 	kfree(data_buf);
 
 	if (!rc) {