From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Tue, 27 Jun 2023 20:20:05 +0000 (-0400)
Subject: bcachefs: Fix leak in backpointers fsck
X-Git-Tag: io_uring-6.7-2023-11-10~119^2~242
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=1fa3e87ac50a24a4f6a71986a4d9bc2f16d0667e;p=linux-block.git

bcachefs: Fix leak in backpointers fsck

We were forgetting to exit a printbuf - whoops.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/backpointers.c b/fs/bcachefs/backpointers.c
index 2641ebef6ae4..a270ff96e9b4 100644
--- a/fs/bcachefs/backpointers.c
+++ b/fs/bcachefs/backpointers.c
@@ -811,8 +811,10 @@ static int check_one_backpointer(struct btree_trans *trans,
 
 	if (fsck_err_on(!k.k, c,
 			"backpointer for missing extent\n  %s",
-			(bch2_bkey_val_to_text(&buf, c, bp.s_c), buf.buf)))
-		return bch2_btree_delete_at_buffered(trans, BTREE_ID_backpointers, bp.k->p);
+			(bch2_bkey_val_to_text(&buf, c, bp.s_c), buf.buf))) {
+		ret = bch2_btree_delete_at_buffered(trans, BTREE_ID_backpointers, bp.k->p);
+		goto out;
+	}
 out:
 fsck_err:
 	bch2_trans_iter_exit(trans, &iter);