From: Eric Dumazet Date: Sun, 21 Apr 2024 18:57:53 +0000 (+0000) Subject: neighbour: fix neigh_master_filtered() X-Git-Tag: net-accept-more-20240515~4^2~159 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=1c04b46cbdddc7882eeb671521035ea884245b9f;p=linux-2.6-block.git neighbour: fix neigh_master_filtered() If we no longer hold RTNL, we must use netdev_master_upper_dev_get_rcu() instead of netdev_master_upper_dev_get(). Fixes: ba0f78069423 ("neighbour: no longer hold RTNL in neigh_dump_info()") Signed-off-by: Eric Dumazet Reviewed-by: Jiri Pirko Link: https://lore.kernel.org/r/20240421185753.1808077-1-edumazet@google.com Signed-off-by: Jakub Kicinski --- diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 0805c00c63d4..af270c202d9a 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -2682,7 +2682,7 @@ static bool neigh_master_filtered(struct net_device *dev, int master_idx) if (!master_idx) return false; - master = dev ? netdev_master_upper_dev_get(dev) : NULL; + master = dev ? netdev_master_upper_dev_get_rcu(dev) : NULL; /* 0 is already used to denote NDA_MASTER wasn't passed, therefore need another * invalid value for ifindex to denote "no master".