From: Matt Roper Date: Wed, 29 Mar 2023 17:33:34 +0000 (-0700) Subject: drm/xe: Don't emit extra MI_BATCH_BUFFER_END in WA batchbuffer X-Git-Tag: v6.8-rc1~21^2~13^2~819 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=1bf1d86f12d4d07108d480878193acd1e4d87668;p=linux-block.git drm/xe: Don't emit extra MI_BATCH_BUFFER_END in WA batchbuffer The MI_BATCH_BUFFER_END is already added automatically by __xe_bb_create_job(); including it in the construction of the workaround batchbuffer results in an unnecessary duplicate. Link: https://lore.kernel.org/r/20230329173334.4015124-4-matthew.d.roper@intel.com Signed-off-by: Matt Roper Reviewed-by: José Roberto de Souza Signed-off-by: Rodrigo Vivi --- diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c index fd7a5b43ba3e..bc821f431c45 100644 --- a/drivers/gpu/drm/xe/xe_gt.c +++ b/drivers/gpu/drm/xe/xe_gt.c @@ -203,8 +203,6 @@ static int emit_wa_job(struct xe_gt *gt, struct xe_engine *e) bb->cs[bb->len++] = entry->set_bits; } } - bb->cs[bb->len++] = MI_NOOP; - bb->cs[bb->len++] = MI_BATCH_BUFFER_END; batch_ofs = xe_bo_ggtt_addr(gt->kernel_bb_pool.bo); job = xe_bb_create_wa_job(e, bb, batch_ofs);