From: Johannes Berg Date: Thu, 14 Apr 2022 12:04:02 +0000 (+0200) Subject: nl80211: don't hold RTNL in color change request X-Git-Tag: for-5.19/block-exec-2022-06-02~49^2~59^2~62 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=1b550a0bebfc0b69d6ec08fe6eb58953a8aec48a;p=linux-block.git nl80211: don't hold RTNL in color change request It's not necessary to hold the RTNL across color change requests, since all the inner locking needs only the wiphy mutex which we already hold as well. Fixes: 0d2ab3aea50b ("nl80211: add support for BSS coloring") Link: https://lore.kernel.org/r/20220414140402.32e03e8c261b.I5e7dc6bc563a129b938c43298da6bb4e812400a5@changeid Signed-off-by: Johannes Berg --- diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 945ed87d12e0..6239d2757f0b 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -16273,8 +16273,7 @@ static const struct genl_small_ops nl80211_small_ops[] = { .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, .doit = nl80211_color_change, .flags = GENL_UNS_ADMIN_PERM, - .internal_flags = NL80211_FLAG_NEED_NETDEV_UP | - NL80211_FLAG_NEED_RTNL, + .internal_flags = NL80211_FLAG_NEED_NETDEV_UP, }, { .cmd = NL80211_CMD_SET_FILS_AAD,