From: ye xingchen Date: Mon, 5 Dec 2022 09:19:16 +0000 (+0800) Subject: fs: nfs: sysfs: use sysfs_emit() to instead of scnprintf() X-Git-Tag: io_uring-6.2-2022-12-19~53^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=19cdc8fa5b9b768f5753eefe3da32fcbafcb0d18;p=linux-block.git fs: nfs: sysfs: use sysfs_emit() to instead of scnprintf() Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen Signed-off-by: Trond Myklebust --- diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c index a6f740366963..26f8ece2a997 100644 --- a/fs/nfs/sysfs.c +++ b/fs/nfs/sysfs.c @@ -82,7 +82,7 @@ static ssize_t nfs_netns_identifier_show(struct kobject *kobj, ssize_t ret; rcu_read_lock(); - ret = scnprintf(buf, PAGE_SIZE, "%s\n", rcu_dereference(c->identifier)); + ret = sysfs_emit(buf, "%s\n", rcu_dereference(c->identifier)); rcu_read_unlock(); return ret; }