From: Liang He <windhl@126.com>
Date: Tue, 19 Jul 2022 09:52:15 +0000 (+0800)
Subject: mmc: cavium-octeon: Add of_node_put() when breaking out of loop
X-Git-Tag: block-6.0-2022-08-12~5^2~6
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=19bbb49acf8d7a03cb83e05624363741a4c3ec6f;p=linux-block.git

mmc: cavium-octeon: Add of_node_put() when breaking out of loop

In octeon_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.

Fixes: 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")
Signed-off-by: Liang He <windhl@126.com>
Acked-by: Robert Richter <rric@kernel.org>
Link: https://lore.kernel.org/r/20220719095216.1241601-1-windhl@126.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---

diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c
index 2c4b2df52adb..12dca91a8ef6 100644
--- a/drivers/mmc/host/cavium-octeon.c
+++ b/drivers/mmc/host/cavium-octeon.c
@@ -277,6 +277,7 @@ static int octeon_mmc_probe(struct platform_device *pdev)
 		if (ret) {
 			dev_err(&pdev->dev, "Error populating slots\n");
 			octeon_mmc_set_shared_power(host, 0);
+			of_node_put(cn);
 			goto error;
 		}
 		i++;