From: Cezary Rojewski Date: Thu, 26 Oct 2023 08:25:58 +0000 (+0200) Subject: ASoC: Intel: Skylake: Fix mem leak when parsing UUIDs fails X-Git-Tag: io_uring-6.7-2023-11-10~21^2~1^2^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=168d97844a61db302dec76d44406e9d4d7106b8e;p=linux-block.git ASoC: Intel: Skylake: Fix mem leak when parsing UUIDs fails Error path in snd_skl_parse_uuids() shall free last allocated module if its instance_id allocation fails. Fixes: f8e066521192 ("ASoC: Intel: Skylake: Fix uuid_module memory leak in failure case") Signed-off-by: Cezary Rojewski Signed-off-by: Amadeusz Sławiński Link: https://lore.kernel.org/r/20231026082558.1864910-1-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/intel/skylake/skl-sst-utils.c b/sound/soc/intel/skylake/skl-sst-utils.c index 57ea815d3f04..b776c58dcf47 100644 --- a/sound/soc/intel/skylake/skl-sst-utils.c +++ b/sound/soc/intel/skylake/skl-sst-utils.c @@ -299,6 +299,7 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, module->instance_id = devm_kzalloc(ctx->dev, size, GFP_KERNEL); if (!module->instance_id) { ret = -ENOMEM; + kfree(module); goto free_uuid_list; }