From: Jacek Anaszewski <j.anaszewski@samsung.com>
Date: Wed, 25 Nov 2015 08:22:19 +0000 (+0100)
Subject: leds: aat1290: Add missing of_node_put
X-Git-Tag: v4.5-rc1~150^2~17
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=0c24199ca9dd0ec1eaddc49ec83ca97bc1f1c233;p=linux-2.6-block.git

leds: aat1290: Add missing of_node_put

The refcount of device_node increases after of_get_next_available_child()
is called. Make sure it is decremented also in case of DT parsing error.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
---

diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index f2259308b92e..def3cf9f7e92 100644
--- a/drivers/leds/leds-aat1290.c
+++ b/drivers/leds/leds-aat1290.c
@@ -275,7 +275,7 @@ static int aat1290_led_parse_dt(struct aat1290_led *led,
 	if (ret < 0) {
 		dev_err(dev,
 			"flash-max-microamp DT property missing\n");
-		return ret;
+		goto err_parse_dt;
 	}
 
 	ret = of_property_read_u32(child_node, "flash-max-timeout-us",
@@ -283,13 +283,14 @@ static int aat1290_led_parse_dt(struct aat1290_led *led,
 	if (ret < 0) {
 		dev_err(dev,
 			"flash-max-timeout-us DT property missing\n");
-		return ret;
+		goto err_parse_dt;
 	}
 
-	of_node_put(child_node);
-
 	*sub_node = child_node;
 
+err_parse_dt:
+	of_node_put(child_node);
+
 	return ret;
 }