From: Christophe Leroy Date: Tue, 22 Jan 2019 14:11:24 +0000 (+0000) Subject: powerpc/traps: fix recoverability of machine check handling on book3s/32 X-Git-Tag: v5.1-rc1~11^2~93 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=0bbea75c476b77fa7d7811d6be911cc7583e640f;p=linux-2.6-block.git powerpc/traps: fix recoverability of machine check handling on book3s/32 Looks like book3s/32 doesn't set RI on machine check, so checking RI before calling die() will always be fatal allthought this is not an issue in most cases. Fixes: b96672dd840f ("powerpc: Machine check interrupt is a non-maskable interrupt") Fixes: daf00ae71dad ("powerpc/traps: restore recoverability of machine_check interrupts") Signed-off-by: Christophe Leroy Cc: stable@vger.kernel.org Signed-off-by: Michael Ellerman --- diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index 040b60293613..b25bc8af7d38 100644 --- a/arch/powerpc/kernel/traps.c +++ b/arch/powerpc/kernel/traps.c @@ -756,15 +756,15 @@ void machine_check_exception(struct pt_regs *regs) if (check_io_access(regs)) goto bail; - /* Must die if the interrupt is not recoverable */ - if (!(regs->msr & MSR_RI)) - nmi_panic(regs, "Unrecoverable Machine check"); - if (!nested) nmi_exit(); die("Machine check", regs, SIGBUS); + /* Must die if the interrupt is not recoverable */ + if (!(regs->msr & MSR_RI)) + nmi_panic(regs, "Unrecoverable Machine check"); + return; bail: