From: Shawn Lin Date: Thu, 6 Jul 2017 08:09:12 +0000 (+0800) Subject: mmc: mxcmmc: check the return value of mxcmci_finish_data X-Git-Tag: v4.14-rc1~116^2~126 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=09954ea9b6d4390555b71b30c5c3b82b6c679cf3;p=linux-2.6-block.git mmc: mxcmmc: check the return value of mxcmci_finish_data We got a compile warning for mxcmmc, drivers/mmc/host/mxcmmc.c: In function 'mxcmci_data_done': drivers/mmc/host/mxcmmc.c:661:6: warning: variable 'data_error' set but not used [-Wunused-but-set-variable] The easiest method is to remove the data_error. But looking into the code closely, I think we should check the return value of mxcmci_finish_data as if it got data->error(the same as data_error), we shouldn't try to read the response. Signed-off-by: Shawn Lin Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index f3c28326c4db..f2b6639634d2 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c @@ -681,6 +681,9 @@ static void mxcmci_data_done(struct mxcmci_host *host, unsigned int stat) spin_unlock_irqrestore(&host->lock, flags); + if (data_error) + return; + mxcmci_read_response(host, stat); host->cmd = NULL;