From: Ansuel Smith Date: Tue, 23 Nov 2021 15:44:46 +0000 (+0100) Subject: net: dsa: qca8k: fix warning in LAG feature X-Git-Tag: block-5.17-2022-01-21~91^2~352 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=0898ca67b86e14207d4feb3f3fea8b87cec5aab1;p=linux-block.git net: dsa: qca8k: fix warning in LAG feature Fix warning reported by bot. Make sure hash is init to 0 and fix wrong logic for hash_type in qca8k_lag_can_offload. Reported-by: kernel test robot Fixes: def975307c01 ("net: dsa: qca8k: add LAG support") Signed-off-by: Ansuel Smith Reviewed-by: Florian Fainelli Link: https://lore.kernel.org/r/20211123154446.31019-1-ansuelsmth@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 6516df08a5d5..d04b25eca250 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -2228,7 +2228,7 @@ qca8k_lag_can_offload(struct dsa_switch *ds, if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH) return false; - if (info->hash_type != NETDEV_LAG_HASH_L2 || + if (info->hash_type != NETDEV_LAG_HASH_L2 && info->hash_type != NETDEV_LAG_HASH_L23) return false; @@ -2242,8 +2242,8 @@ qca8k_lag_setup_hash(struct dsa_switch *ds, { struct qca8k_priv *priv = ds->priv; bool unique_lag = true; + u32 hash = 0; int i, id; - u32 hash; id = dsa_lag_id(ds->dst, lag);