From: Uwe Kleine-König Date: Tue, 4 May 2021 13:25:37 +0000 (+0200) Subject: pwm: berlin: Don't check the return code of pwmchip_remove() X-Git-Tag: v5.14-rc1~42^2~23 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=0512f0503b051a98608a9b0d33b75482b960a313;p=linux-block.git pwm: berlin: Don't check the return code of pwmchip_remove() pwmchip_remove() always returns 0. Don't use the value to make it possible to eventually change the function to return void. This is a good thing as pwmchip_remove() is usually called from a remove function (mostly for platform devices) and their return value is ignored by the device core anyhow. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c index c17d7e8f0470..5537b5f6dd5d 100644 --- a/drivers/pwm/pwm-berlin.c +++ b/drivers/pwm/pwm-berlin.c @@ -256,12 +256,12 @@ static int berlin_pwm_probe(struct platform_device *pdev) static int berlin_pwm_remove(struct platform_device *pdev) { struct berlin_pwm_chip *bpc = platform_get_drvdata(pdev); - int ret; - ret = pwmchip_remove(&bpc->chip); + pwmchip_remove(&bpc->chip); + clk_disable_unprepare(bpc->clk); - return ret; + return 0; } #ifdef CONFIG_PM_SLEEP