ipv6: anycast: use call_rcu_hurry() in aca_put()
authorEric Dumazet <edumazet@google.com>
Mon, 29 Apr 2024 18:36:43 +0000 (18:36 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 May 2024 10:46:21 +0000 (11:46 +0100)
This is a followup of commit b5327b9a300e ("ipv6: use
call_rcu_hurry() in fib6_info_release()").

I had another pmtu.sh failure, and found another lazy
call_rcu() causing this failure.

aca_free_rcu() calls fib6_info_release() which releases
devices references.

We must not delay it too much or risk unregister_netdevice/ref_tracker
traces because references to netdev are not released in time.

This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/anycast.c

index 0f2506e3535925468dcc5fa6cc30ae0952a67ea7..0627c4c18d1a5067a668da778ad444855194cbeb 100644 (file)
@@ -252,9 +252,8 @@ static void aca_free_rcu(struct rcu_head *h)
 
 static void aca_put(struct ifacaddr6 *ac)
 {
-       if (refcount_dec_and_test(&ac->aca_refcnt)) {
-               call_rcu(&ac->rcu, aca_free_rcu);
-       }
+       if (refcount_dec_and_test(&ac->aca_refcnt))
+               call_rcu_hurry(&ac->rcu, aca_free_rcu);
 }
 
 static struct ifacaddr6 *aca_alloc(struct fib6_info *f6i,