spmi: pmic-arb: add missing newline in dev_err format strings
authorDavid Collins <quic_collinsd@quicinc.com>
Thu, 25 Jul 2024 16:46:33 +0000 (09:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2024 11:49:28 +0000 (13:49 +0200)
dev_err() format strings should end with '\n'.  Several such
format strings in the spmi-pmic-arb driver are missing it.
Add newlines where needed.

Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter")
Signed-off-by: David Collins <quic_collinsd@quicinc.com>
Link: https://lore.kernel.org/r/20240703221248.3640490-1-quic_collinsd@quicinc.com
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20240725164636.3362690-4-sboyd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/spmi/spmi-pmic-arb.c

index b6880c13163cec4323e9e298de46e2ab3e7cb26d..9ba9495fcc4bae401fa054f7da244d35f1c120ca 100644 (file)
@@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, u8 sid,
 
        *offset = rc;
        if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
-               dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
+               dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
                        PMIC_ARB_MAX_TRANS_BYTES, len);
                return  -EINVAL;
        }
@@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_bus *bus, u8 opc,
 
        *offset = rc;
        if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
-               dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
+               dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
                        PMIC_ARB_MAX_TRANS_BYTES, len);
                return  -EINVAL;
        }
@@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
 
        index = of_property_match_string(node, "reg-names", "cnfg");
        if (index < 0) {
-               dev_err(dev, "cnfg reg region missing");
+               dev_err(dev, "cnfg reg region missing\n");
                return -EINVAL;
        }
 
@@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
 
        index = of_property_match_string(node, "reg-names", "intr");
        if (index < 0) {
-               dev_err(dev, "intr reg region missing");
+               dev_err(dev, "intr reg region missing\n");
                return -EINVAL;
        }