spi: ath79: remove spi-master setup and cleanup assignment
authorDavid Bauer <mail@david-bauer.net>
Wed, 3 Mar 2021 16:08:37 +0000 (17:08 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 12:25:15 +0000 (12:25 +0000)
This removes the assignment of setup and cleanup functions for the ath79
target. Assigning the setup-method will lead to 'setup_transfer' not
being assigned in spi_bitbang_init. Because of this, performing any
TX/RX operation will lead to a kernel oops.

Also drop the redundant cleanup assignment, as it's also assigned in
spi_bitbang_init.

Signed-off-by: David Bauer <mail@david-bauer.net>
Link: https://lore.kernel.org/r/20210303160837.165771-2-mail@david-bauer.net
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-ath79.c

index 436327fb58de6605dd1aa4ee9d08b3db157f8f64..98ace748cd986af7ec3d038b9b8f5ca7da64ecf7 100644 (file)
@@ -156,8 +156,6 @@ static int ath79_spi_probe(struct platform_device *pdev)
 
        master->use_gpio_descriptors = true;
        master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32);
-       master->setup = spi_bitbang_setup;
-       master->cleanup = spi_bitbang_cleanup;
        master->flags = SPI_MASTER_GPIO_SS;
        if (pdata) {
                master->bus_num = pdata->bus_num;