media: pci: mgb4: Refactor struct resources

The struct resource end field signifies the end address not the
relative offset from the start field i.e size == (end - start) + 1.

Amend the .end field to specify the end address not the relative size
from the offset as is currently given.

Fixes cocci check:
drivers/media/pci/mgb4/mgb4_regs.c:13:22-25: WARNING: Suspicious code. resource_size is maybe missing with res

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-1-3c4865f5a4b0@chromium.org
Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/pci/mgb4/mgb4_core.c b/drivers/media/pci/mgb4/mgb4_core.c
index 9bcf10a77fd38dee1cc6ee7c8ff069eebf143b73..60498a5abebf3bea3699fe596cdfeaca11970e33 100644 (file)
--- a/drivers/media/pci/mgb4/mgb4_core.c
+++ b/drivers/media/pci/mgb4/mgb4_core.c
@@ -493,13 +493,13 @@ static int mgb4_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        struct mgb4_dev *mgbdev;
        struct resource video = {
                .start  = 0x0,
-               .end    = 0x100,
+               .end    = 0xff,
                .flags  = IORESOURCE_MEM,
                .name   = "mgb4-video",
        };
        struct resource cmt = {
                .start  = 0x1000,
-               .end    = 0x1800,
+               .end    = 0x17ff,
                .flags  = IORESOURCE_MEM,
                .name   = "mgb4-cmt",
        };

diff --git a/drivers/media/pci/mgb4/mgb4_regs.c b/drivers/media/pci/mgb4/mgb4_regs.c
index 53d4e4503a74cf813a7eef33b5ca903f9033981d..31befd722d72ddd95958b84baf0820075c3f39a1 100644 (file)
--- a/drivers/media/pci/mgb4/mgb4_regs.c
+++ b/drivers/media/pci/mgb4/mgb4_regs.c
@@ -10,7 +10,7 @@
 int mgb4_regs_map(struct resource *res, struct mgb4_regs *regs)
 {
        regs->mapbase = res->start;
-       regs->mapsize = res->end - res->start;
+       regs->mapsize = resource_size(res);
 
        if (!request_mem_region(regs->mapbase, regs->mapsize, res->name))
                return -EINVAL;