leds: aw200xx: Annotate struct aw200xx with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 15 Sep 2023 20:09:39 +0000 (13:09 -0700)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:25 +0000 (11:28 +0000)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct aw200xx.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230915200938.never.767-kees@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-aw200xx.c

index 691a743cc9b0fdb6c0b4df4ecc402cbc30dd37b3..4d517cace3e797aefefb3d3885a13025df55601f 100644 (file)
@@ -112,7 +112,7 @@ struct aw200xx {
        struct mutex mutex;
        u32 num_leds;
        u32 display_rows;
-       struct aw200xx_led leds[];
+       struct aw200xx_led leds[] __counted_by(num_leds);
 };
 
 static ssize_t dim_show(struct device *dev, struct device_attribute *devattr,