crypto: lib/mpi - delete unnecessary condition
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 4 Jul 2024 15:25:05 +0000 (10:25 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 12 Jul 2024 23:50:28 +0000 (11:50 +1200)
We checked that "nlimbs" is non-zero in the outside if statement so delete
the duplicate check here.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
lib/crypto/mpi/mpi-bit.c

index 070ba784c9f15ad85d0ee0b9102b0606c532b58d..e08fc202ea5cf8ff3b2146cc9e23c928345c020a 100644 (file)
@@ -212,12 +212,10 @@ void mpi_rshift(MPI x, MPI a, unsigned int n)
                        return;
                }
 
-               if (nlimbs) {
-                       for (i = 0; i < x->nlimbs - nlimbs; i++)
-                               x->d[i] = x->d[i+nlimbs];
-                       x->d[i] = 0;
-                       x->nlimbs -= nlimbs;
-               }
+               for (i = 0; i < x->nlimbs - nlimbs; i++)
+                       x->d[i] = x->d[i+nlimbs];
+               x->d[i] = 0;
+               x->nlimbs -= nlimbs;
 
                if (x->nlimbs && nbits)
                        mpihelp_rshift(x->d, x->d, x->nlimbs, nbits);