media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci_remove()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 20 May 2024 09:55:54 +0000 (11:55 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 28 May 2024 06:00:14 +0000 (08:00 +0200)
pcim_iomap_regions() and pcim_enable_device() are used in the probe. So
the corresponding managed resources don't need to be freed explicitly in
the remove function.

Remove the incorrect pci_release_regions() and pci_disable_device() calls.

Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/intel/ipu6/ipu6.c

index d2bebd208461518549528a8f41765d1a6eac8df7..f587f609259d7c6810d0b401b515e2595966cf60 100644 (file)
@@ -727,9 +727,6 @@ static void ipu6_pci_remove(struct pci_dev *pdev)
        pm_runtime_forbid(&pdev->dev);
        pm_runtime_get_noresume(&pdev->dev);
 
-       pci_release_regions(pdev);
-       pci_disable_device(pdev);
-
        release_firmware(isp->cpd_fw);
 
        ipu6_mmu_cleanup(psys_mmu);