ext4: show the default enabled prefetch_block_bitmaps option
authorBaokun Li <libaokun1@huawei.com>
Tue, 8 Oct 2024 12:01:34 +0000 (20:01 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 13 Nov 2024 04:49:51 +0000 (23:49 -0500)
After commit 21175ca434c5 ("ext4: make prefetch_block_bitmaps default"),
we enable 'prefetch_block_bitmaps' by default, but this is not shown in
the '/proc/fs/ext4/sdx/options' procfs interface.

This makes it impossible to distinguish whether the feature is enabled by
default or not, so 'prefetch_block_bitmaps' is shown in the 'options'
procfs interface when prefetch_block_bitmaps is enabled by default.

This makes it easy to notice changes to the default mount options between
versions through the '/proc/fs/ext4/sdx/options' procfs interface.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20241008120134.3758097-1-libaokun@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c

index 8a0af97e5d90c7d796c35ffb080049330d858043..e7d3c2e209ba19b117aa5b130f52b517e4c7d348 100644 (file)
@@ -3030,6 +3030,9 @@ static int _ext4_show_options(struct seq_file *seq, struct super_block *sb,
                SEQ_OPTS_PUTS("mb_optimize_scan=1");
        }
 
+       if (nodefs && !test_opt(sb, NO_PREFETCH_BLOCK_BITMAPS))
+               SEQ_OPTS_PUTS("prefetch_block_bitmaps");
+
        ext4_show_quota_options(seq, sb);
        return 0;
 }