objtool: Upgrade "Linked object detected" warning to error
authorJosh Poimboeuf <jpoimboe@kernel.org>
Fri, 14 Mar 2025 19:29:06 +0000 (12:29 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 17 Mar 2025 10:36:01 +0000 (11:36 +0100)
Force the user to fix their cmdline if they forget the '--link' option.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Brendan Jackman <jackmanb@google.com>
Link: https://lore.kernel.org/r/8380bbf3a0fa86e03fd63f60568ae06a48146bc1.1741975349.git.jpoimboe@kernel.org
tools/objtool/builtin-check.c

index 36d81a455b0127b2a6b113949a3b56122c7183ac..79843512a51b1e64f87c7821693da896dbe1baf5 100644 (file)
@@ -198,8 +198,8 @@ int objtool_run(int argc, const char **argv)
                return 1;
 
        if (!opts.link && has_multiple_files(file->elf)) {
-               ERROR("Linked object detected, forcing --link");
-               opts.link = true;
+               ERROR("Linked object requires --link");
+               goto err;
        }
 
        ret = check(file);