selftest/net/ovpn: fix TCP socket creation
authorAntonio Quartulli <antonio@openvpn.net>
Tue, 20 May 2025 14:42:39 +0000 (16:42 +0200)
committerAntonio Quartulli <antonio@openvpn.net>
Tue, 3 Jun 2025 11:08:15 +0000 (13:08 +0200)
TCP sockets cannot be created with AF_UNSPEC, but
one among the supported family must be used.

Since commit 944f8b6abab6 ("selftest/net/ovpn: extend
coverage with more test cases") the default address
family for all tests was changed from AF_INET to AF_UNSPEC,
thus breaking all TCP cases.

Restore AF_INET as default address family for TCP listeners.

Fixes: 944f8b6abab6 ("selftest/net/ovpn: extend coverage with more test cases")
Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
tools/testing/selftests/net/ovpn/ovpn-cli.c

index de9c26f98b2e5ec828c823a5f255d43bf75c73a7..9201f2905f2ceeddf7640d82874ef04ffe182091 100644 (file)
@@ -2166,6 +2166,7 @@ static int ovpn_parse_cmd_args(struct ovpn_ctx *ovpn, int argc, char *argv[])
 
                ovpn->peers_file = argv[4];
 
+               ovpn->sa_family = AF_INET;
                if (argc > 5 && !strcmp(argv[5], "ipv6"))
                        ovpn->sa_family = AF_INET6;
                break;