staging: gpib: Correct CamelCase for EVENT enums
authorMichael Rubin <matchstick@neverthere.org>
Tue, 8 Apr 2025 22:20:27 +0000 (22:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Apr 2025 14:34:50 +0000 (16:34 +0200)
Adhere to Linux kernel coding style.

Reported by checkpatch

CHECK: Avoid CamelCase: <EventNone>
CHECK: Avoid CamelCase: <EventDevTrg>
CHECK: Avoid CamelCase: <EventDevClr>
CHECK: Avoid CamelCase: <EventIfc>

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/common/gpib_os.c
drivers/staging/gpib/eastwood/fluke_gpib.c
drivers/staging/gpib/fmh_gpib/fmh_gpib.c
drivers/staging/gpib/ines/ines_gpib.c
drivers/staging/gpib/nec7210/nec7210.c
drivers/staging/gpib/tms9914/tms9914.c
drivers/staging/gpib/tnt4882/tnt4882_gpib.c
drivers/staging/gpib/uapi/gpib_user.h

index 8456b97290b80e0270dceeab9fb19a5a22ff4c9b..fdc4f6266f07d4b3e4375e2eada3d24e7ac2f196 100644 (file)
@@ -1888,9 +1888,9 @@ int push_gpib_event(struct gpib_board *board, short event_type)
        retval = push_gpib_event_nolock(board, event_type);
        spin_unlock_irqrestore(&board->event_queue.lock, flags);
 
-       if (event_type == EventDevTrg)
+       if (event_type == EVENT_DEV_TRG)
                board->status |= DTAS;
-       if (event_type == EventDevClr)
+       if (event_type == EVENT_DEV_CLR)
                board->status |= DCAS;
 
        return retval;
@@ -1904,7 +1904,7 @@ static int pop_gpib_event_nolock(struct gpib_board *board, gpib_event_queue_t *q
        gpib_event_t *event;
 
        if (num_gpib_events(queue) == 0) {
-               *event_type = EventNone;
+               *event_type = EVENT_NONE;
                return 0;
        }
 
index a6b1ac169f94a4766d0fff27bd608e214568c33b..d289c321c1532a196e8750f84182451119988580 100644 (file)
@@ -802,7 +802,7 @@ irqreturn_t fluke_gpib_internal_interrupt(struct gpib_board *board)
        status2 = read_byte(nec_priv, ISR2);
 
        if (status0 & FLUKE_IFCI_BIT) {
-               push_gpib_event(board, EventIFC);
+               push_gpib_event(board, EVENT_IFC);
                retval = IRQ_HANDLED;
        }
 
index 53f4b3fccc3c4865bee71d4d7132e3197f6bc84d..733433d7fc3feb1753fbf64af715319f140ce724 100644 (file)
@@ -1136,7 +1136,7 @@ irqreturn_t fmh_gpib_internal_interrupt(struct gpib_board *board)
        fifo_status = fifos_read(priv, FIFO_CONTROL_STATUS_REG);
 
        if (status0 & IFC_INTERRUPT_BIT) {
-               push_gpib_event(board, EventIFC);
+               push_gpib_event(board, EVENT_IFC);
                retval = IRQ_HANDLED;
        }
 
index d93eb05dab903811f16a7347227e9f4aec047a4a..93897088f6f240297dbec675f8b09225e4dee472 100644 (file)
@@ -295,7 +295,7 @@ irqreturn_t ines_interrupt(struct gpib_board *board)
        isr3_bits = ines_inb(priv, ISR3);
        isr4_bits = ines_inb(priv, ISR4);
        if (isr3_bits & IFC_ACTIVE_BIT) {
-               push_gpib_event(board, EventIFC);
+               push_gpib_event(board, EVENT_IFC);
                wake++;
        }
        if (isr3_bits & FIFO_ERROR_BIT)
index 846c0a3fa1dc31eaadb46a4d767cf271c50ef6b4..9b4870f1b421d3b5c64e6cbb3954c94c769acc5d 100644 (file)
@@ -932,13 +932,13 @@ irqreturn_t nec7210_interrupt_have_status(struct gpib_board *board,
 
                // ignore device clear events if we are controller in charge
                if ((address_status_bits & HR_CIC) == 0) {
-                       push_gpib_event(board, EventDevClr);
+                       push_gpib_event(board, EVENT_DEV_CLR);
                        set_bit(DEV_CLEAR_BN, &priv->state);
                }
        }
 
        if (status1 & HR_DET)
-               push_gpib_event(board, EventDevTrg);
+               push_gpib_event(board, EVENT_DEV_TRG);
 
        // Addressing status has changed
        if (status2 & HR_ADSC)
index 2abda9d7dfcbe8046109d01247648c8472fbd373..f7ad0b47ebb8cfdd8dbcfe2a7e1f927ec9e2fb56 100644 (file)
@@ -774,18 +774,18 @@ irqreturn_t tms9914_interrupt_have_status(struct gpib_board *board, struct tms99
        }
 
        if (status1 & HR_IFC) {
-               push_gpib_event(board, EventIFC);
+               push_gpib_event(board, EVENT_IFC);
                clear_bit(CIC_NUM, &board->status);
        }
 
        if (status1 & HR_GET) {
-               push_gpib_event(board, EventDevTrg);
+               push_gpib_event(board, EVENT_DEV_TRG);
                // clear dac holdoff
                write_byte(priv, AUX_VAL, AUXCR);
        }
 
        if (status1 & HR_DCAS) {
-               push_gpib_event(board, EventDevClr);
+               push_gpib_event(board, EVENT_DEV_CLR);
                // clear dac holdoff
                write_byte(priv, AUX_VAL, AUXCR);
                set_bit(DEV_CLEAR_BN, &priv->state);
index c35b084b6fd0fbe003808e857f0e55ffc9fbe2c5..caf53f8ded2e5bb2b99172d330c32385b188f28c 100644 (file)
@@ -566,7 +566,7 @@ static irqreturn_t tnt4882_internal_interrupt(struct gpib_board *board)
        imr3_bits = priv->imr3_bits;
 
        if (isr0_bits & TNT_IFCI_BIT)
-               push_gpib_event(board, EventIFC);
+               push_gpib_event(board, EVENT_IFC);
        //XXX don't need this wakeup, one below should do?
 //             wake_up_interruptible(&board->wait);
 
index 5ff4588686fde328cb78448694988eaa792b3757..b0c131196a0099e5deda5c354031939a1bbeb4b4 100644 (file)
@@ -335,10 +335,10 @@ enum {
 };
 
 enum gpib_events {
-       EventNone = 0,
-       EventDevTrg = 1,
-       EventDevClr = 2,
-       EventIFC = 3
+       EVENT_NONE = 0,
+       EVENT_DEV_TRG = 1,
+       EVENT_DEV_CLR = 2,
+       EVENT_IFC = 3
 };
 
 enum gpib_stb {