drm/amd/powerplay: Zero out power data in AMDGPU_PP_SENSOR_GPU_POWER readout
authorTom St Denis <tom.stdenis@amd.com>
Tue, 6 Feb 2018 19:00:01 +0000 (14:00 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 19 Feb 2018 19:19:38 +0000 (14:19 -0500)
Since 12 of the 16 bytes are not initialized with anything let's ensure they're
sensibly zeroed out otherwise debugfs callers will read back garbage
(because they assume debugfs wrote sensible data back...)

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c

index 5e3c63f8b62a8d734baa1645add48a2e9c6ea095..341fba5f71714a7c41fa5957eff5c79f4495a63b 100644 (file)
@@ -3889,7 +3889,9 @@ static int vega10_get_gpu_power(struct pp_hwmgr *hwmgr,
                        return -EINVAL);
 
        vega10_read_arg_from_smc(hwmgr, &value);
+
        /* power value is an integer */
+       memset(query, 0, sizeof *query);
        query->average_gpu_power = value << 8;
 
        return 0;