mwifiex: Log an error on command failure during key-material upload

Sometimes the KEY_MATERIAL command can fail with the 88W8897 firmware
(when this happens exactly seems pretty random). This appears to prevent
the access point from starting, so it seems like a good idea to log an
error in that case.

Signed-off-by: Jonas Dreßler <verdre@v0yd.nl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211016153244.24353-3-verdre@v0yd.nl

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 987558c4fc79477b7335471282da1bbf086da788..6f23ec34e2e2f64e30397dbde5fc2e6a880c296d 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -519,8 +519,14 @@ mwifiex_cfg80211_set_default_mgmt_key(struct wiphy *wiphy,
        encrypt_key.is_igtk_def_key = true;
        eth_broadcast_addr(encrypt_key.mac_addr);
 
-       return mwifiex_send_cmd(priv, HostCmd_CMD_802_11_KEY_MATERIAL,
-                               HostCmd_ACT_GEN_SET, true, &encrypt_key, true);
+       if (mwifiex_send_cmd(priv, HostCmd_CMD_802_11_KEY_MATERIAL,
+                            HostCmd_ACT_GEN_SET, true, &encrypt_key, true)) {
+               mwifiex_dbg(priv->adapter, ERROR,
+                           "Sending KEY_MATERIAL command failed\n");
+               return -1;
+       }
+
+       return 0;
 }
 
 /*