spi: offload: check for match callback when a trigger is being registered
authorAndres Urian Florez <andres.emb.sys@gmail.com>
Fri, 18 Apr 2025 22:47:49 +0000 (17:47 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 21 Apr 2025 16:22:29 +0000 (17:22 +0100)
Make match a required callback when a new trigger is being registered,
this allows that other functions like spi_offload_trigger_get() could
safely invoke the callback when it is required

In v2:
- improve readability of the condition

Signed-off-by: Andres Urian Florez <andres.emb.sys@gmail.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250418224750.46219-1-andres.emb.sys@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-offload.c

index 6bad042fe4373e8b91dae3154ef5e22744a4acd0..21a0f3a3a1762b29bb6599558187e67c183739e5 100644 (file)
@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev,
 {
        struct spi_offload_trigger *trigger;
 
-       if (!info->fwnode || !info->ops)
+       if (!info->fwnode || !info->ops || !info->ops->match)
                return -EINVAL;
 
        trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);