platform/x86: x86-android-tablets: Don't return -EPROBE_DEFER from a non probe()...

The x86-android-tablets code all runs from module_init, so returning
-EPROBE_DEFER is not appropriate. Instead log an error and bail.

This path should never get hit since PINCTRL_BAYTRAIL is a bool.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211229231431.437982-5-hdegoede@redhat.com

diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c
index 4a04da27a3f4ef3243e03d429369fb60ed66c9f3..ea033d7f443968b72515d53a49768975aa173c4b 100644 (file)
--- a/drivers/platform/x86/x86-android-tablets.c
+++ b/drivers/platform/x86/x86-android-tablets.c
@@ -63,8 +63,10 @@ static int x86_acpi_irq_helper_get(const struct x86_acpi_irq_data *data)
        case X86_ACPI_IRQ_TYPE_GPIOINT:
                /* Like acpi_dev_gpio_irq_get(), but without parsing ACPI resources */
                chip = gpiochip_find(data->chip, x86_acpi_irq_helper_gpiochip_find);
-               if (!chip)
-                       return -EPROBE_DEFER;
+               if (!chip) {
+                       pr_err("error cannot find GPIO chip %s\n", data->chip);
+                       return -ENODEV;
+               }
 
                gpiod = gpiochip_get_desc(chip, data->index);
                if (IS_ERR(gpiod)) {