perf evsel: perf_evsel__name(NULL) is valid, no need to check evsel
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 3 Jul 2019 19:12:51 +0000 (16:12 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 9 Jul 2019 12:33:55 +0000 (09:33 -0300)
It'll return "unknown", no need to open code it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-4okvjmm18arjrcyfhuahgfxm@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-report.c
tools/perf/util/session.c

index aef59f318a670e8303d8b134f89df9e2f7ae0c60..93d4b12e248ef233cd999417af3eebf3f98fa680 100644 (file)
@@ -298,7 +298,7 @@ static int process_read_event(struct perf_tool *tool,
        struct report *rep = container_of(tool, struct report, tool);
 
        if (rep->show_threads) {
-               const char *name = evsel ? perf_evsel__name(evsel) : "unknown";
+               const char *name = perf_evsel__name(evsel);
                int err = perf_read_values_add_value(&rep->show_threads_values,
                                           event->read.pid, event->read.tid,
                                           evsel->idx,
index 2e61dd6a3574e02dbbe0c192a1acd4e15939b187..e3463df18493237995066ce7cfcec38074c1bbdd 100644 (file)
@@ -1246,7 +1246,7 @@ static void dump_read(struct perf_evsel *evsel, union perf_event *event)
                return;
 
        printf(": %d %d %s %" PRIu64 "\n", event->read.pid, event->read.tid,
-              evsel ? perf_evsel__name(evsel) : "FAIL",
+              perf_evsel__name(evsel),
               event->read.value);
 
        if (!evsel)