dm persistent data: fix memory allocation failure
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 13 Aug 2024 14:35:14 +0000 (16:35 +0200)
committerMikulas Patocka <mpatocka@redhat.com>
Tue, 13 Aug 2024 19:14:21 +0000 (21:14 +0200)
kmalloc is unreliable when allocating more than 8 pages of memory. It may
fail when there is plenty of free memory but the memory is fragmented.
Zdenek Kabelac observed such failure in his tests.

This commit changes kmalloc to kvmalloc - kvmalloc will fall back to
vmalloc if the large allocation fails.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Cc: stable@vger.kernel.org
drivers/md/persistent-data/dm-space-map-metadata.c

index 04698fd03e6069eb05ddce43aa13cd9f96fdbf23..d48c4fafc779892fbcf66113bb3bce51b98054eb 100644 (file)
@@ -277,7 +277,7 @@ static void sm_metadata_destroy(struct dm_space_map *sm)
 {
        struct sm_metadata *smm = container_of(sm, struct sm_metadata, sm);
 
-       kfree(smm);
+       kvfree(smm);
 }
 
 static int sm_metadata_get_nr_blocks(struct dm_space_map *sm, dm_block_t *count)
@@ -772,7 +772,7 @@ struct dm_space_map *dm_sm_metadata_init(void)
 {
        struct sm_metadata *smm;
 
-       smm = kmalloc(sizeof(*smm), GFP_KERNEL);
+       smm = kvmalloc(sizeof(*smm), GFP_KERNEL);
        if (!smm)
                return ERR_PTR(-ENOMEM);