projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b54b600
)
bpftool: Fix memory leak in do_build_table_cb
author
Miaoqian Lin
<linmq006@gmail.com>
Tue, 6 Dec 2022 07:19:06 +0000
(11:19 +0400)
committer
Daniel Borkmann
<daniel@iogearbox.net>
Tue, 6 Dec 2022 20:20:42 +0000
(21:20 +0100)
strdup() allocates memory for path. We need to release the memory in the
following error path. Add free() to avoid memory leak.
Fixes:
8f184732b60b
("bpftool: Switch to libbpf's hashmap for pinned paths of BPF objects")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link:
https://lore.kernel.org/bpf/20221206071906.806384-1-linmq006@gmail.com
tools/bpf/bpftool/common.c
patch
|
blob
|
blame
|
history
diff --git
a/tools/bpf/bpftool/common.c
b/tools/bpf/bpftool/common.c
index c90b756945e3213fb022894395d1e9e330008e0f..62003204257685c33a14eee9fa336ccfac318948 100644
(file)
--- a/
tools/bpf/bpftool/common.c
+++ b/
tools/bpf/bpftool/common.c
@@
-501,6
+501,7
@@
static int do_build_table_cb(const char *fpath, const struct stat *sb,
if (err) {
p_err("failed to append entry to hashmap for ID %u, path '%s': %s",
pinned_info.id, path, strerror(errno));
+ free(path);
goto out_close;
}