drm/msm/dpu: Remove useless checks in dpu_encoder
authorSean Paul <seanpaul@chromium.org>
Fri, 5 Nov 2021 03:04:26 +0000 (23:04 -0400)
committerRob Clark <robdclark@chromium.org>
Tue, 7 Dec 2021 22:47:10 +0000 (14:47 -0800)
A couple more useless checks to remove in dpu_encoder.

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-sean@poorly.run
Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-10-sean@poorly.run
Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-10-sean@poorly.run
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-None
Link: https://lore.kernel.org/r/20211105030434.2828845-10-sean@poorly.run
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

index e7ee4cfb8461eb3761daf63a1b1f0f8592a735ed..cc57c615be67b1cff229cbcb16125491d0c4752e 100644 (file)
@@ -1148,10 +1148,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc)
        struct msm_drm_private *priv;
        struct drm_display_mode *cur_mode = NULL;
 
-       if (!drm_enc) {
-               DPU_ERROR("invalid encoder\n");
-               return;
-       }
        dpu_enc = to_dpu_encoder_virt(drm_enc);
 
        mutex_lock(&dpu_enc->enc_lock);
@@ -1197,14 +1193,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc)
        struct msm_drm_private *priv;
        int i = 0;
 
-       if (!drm_enc) {
-               DPU_ERROR("invalid encoder\n");
-               return;
-       } else if (!drm_enc->dev) {
-               DPU_ERROR("invalid dev\n");
-               return;
-       }
-
        dpu_enc = to_dpu_encoder_virt(drm_enc);
        DPU_DEBUG_ENC(dpu_enc, "\n");