powerpc/32: enter syscall with MSR_EE inconditionaly set
authorChristophe Leroy <christophe.leroy@c-s.fr>
Tue, 30 Apr 2019 12:38:58 +0000 (12:38 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 2 May 2019 15:20:27 +0000 (01:20 +1000)
syscalls are expected to be entered with MSR_EE set. Lets
make it inconditional by forcing MSR_EE on syscalls.

This patch adds EXC_XFER_SYS for that.

Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
[splited out from benh RFC patch]

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/head_32.S
arch/powerpc/kernel/head_32.h
arch/powerpc/kernel/head_40x.S
arch/powerpc/kernel/head_44x.S
arch/powerpc/kernel/head_8xx.S
arch/powerpc/kernel/head_booke.h
arch/powerpc/kernel/head_fsl_booke.S

index f98e6b461238056cf11e49d9a2dcaa66637f2088..c5fd76d0caf6b58888d4a89836b79c94ba423a9b 100644 (file)
@@ -375,7 +375,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_FPU_UNAVAILABLE)
        DO_KVM  0xc00
 SystemCall:
        EXCEPTION_PROLOG
-       EXC_XFER_EE_LITE(0xc00, DoSyscall)
+       EXC_XFER_SYS(0xc00, DoSyscall)
 
 /* Single step - not used on 601 */
        EXCEPTION(0xd00, SingleStep, single_step_exception, EXC_XFER_STD)
index aa0131bb09b5067085fae83a0a846427680b7152..7221418a883fc82452746906a1012f3ab2fdbe4c 100644 (file)
@@ -123,6 +123,10 @@ label:
        EXC_XFER_TEMPLATE(hdlr, n+1, MSR_KERNEL, NOCOPY, transfer_to_handler, \
                          ret_from_except)
 
+#define EXC_XFER_SYS(n, hdlr)          \
+       EXC_XFER_TEMPLATE(hdlr, n+1, MSR_KERNEL | MSR_EE, NOCOPY, transfer_to_handler, \
+                         ret_from_except)
+
 #define EXC_XFER_EE(n, hdlr)           \
        EXC_XFER_TEMPLATE(hdlr, n, MSR_KERNEL, COPY_EE, transfer_to_handler_full, \
                          ret_from_except_full)
index b3a2e55e1c15ed809f958941fb3c66b94a103046..3e1b8a85cc0db21ec951de3f95c3c4b07a53d63b 100644 (file)
@@ -350,7 +350,7 @@ _ENTRY(saved_ksp_limit)
 /* 0x0C00 - System Call Exception */
        START_EXCEPTION(0x0C00, SystemCall)
        EXCEPTION_PROLOG
-       EXC_XFER_EE_LITE(0xc00, DoSyscall)
+       EXC_XFER_SYS(0xc00, DoSyscall)
 
        EXCEPTION(0x0D00, Trap_0D, unknown_exception, EXC_XFER_EE)
        EXCEPTION(0x0E00, Trap_0E, unknown_exception, EXC_XFER_EE)
index 34a5df827b38e58b10d5511b3bb958dd34a8809f..19268713b692996a87518b8aa59ccfaf19e1a4da 100644 (file)
@@ -286,7 +286,7 @@ interrupt_base:
        /* System Call Interrupt */
        START_EXCEPTION(SystemCall)
        NORMAL_EXCEPTION_PROLOG(BOOKE_INTERRUPT_SYSCALL)
-       EXC_XFER_EE_LITE(0x0c00, DoSyscall)
+       EXC_XFER_SYS(0x0c00, DoSyscall)
 
        /* Auxiliary Processor Unavailable Interrupt */
        EXCEPTION(0x2020, BOOKE_INTERRUPT_AP_UNAVAIL, \
index 14c3eb3267b82b83a7c89fb6dad967c6ddfe7fe6..aa8e629f772585a41d1cc11f522a5a6ca0eb2eb4 100644 (file)
@@ -186,7 +186,7 @@ Alignment:
        . = 0xc00
 SystemCall:
        EXCEPTION_PROLOG
-       EXC_XFER_EE_LITE(0xc00, DoSyscall)
+       EXC_XFER_SYS(0xc00, DoSyscall)
 
 /* Single step - not used on 601 */
        EXCEPTION(0xd00, SingleStep, single_step_exception, EXC_XFER_STD)
index 1b22a8dea399687b6692b94186d377212e544aea..612f54ba11259a48f9597b56004fdeb49ae155ce 100644 (file)
@@ -251,6 +251,10 @@ label:
        EXC_XFER_TEMPLATE(hdlr, n+1, MSR_KERNEL, NOCOPY, transfer_to_handler, \
                          ret_from_except)
 
+#define EXC_XFER_SYS(n, hdlr)                                          \
+       EXC_XFER_TEMPLATE(hdlr, n+1, MSR_KERNEL | MSR_EE, NOCOPY, transfer_to_handler, \
+                         ret_from_except)
+
 #define EXC_XFER_EE(n, hdlr)           \
        EXC_XFER_TEMPLATE(hdlr, n, MSR_KERNEL, COPY_EE, transfer_to_handler_full, \
                          ret_from_except_full)
index 567e0ed45ca8171a6abb4f09815339bd870b48f2..a7bebb99639307885f42959cc128dec95bf8b2c5 100644 (file)
@@ -414,7 +414,7 @@ interrupt_base:
        /* System Call Interrupt */
        START_EXCEPTION(SystemCall)
        NORMAL_EXCEPTION_PROLOG(SYSCALL)
-       EXC_XFER_EE_LITE(0x0c00, DoSyscall)
+       EXC_XFER_SYS(0x0c00, DoSyscall)
 
        /* Auxiliary Processor Unavailable Interrupt */
        EXCEPTION(0x2900, AP_UNAVAIL, AuxillaryProcessorUnavailable, \