btrfs: remove detached list from struct btrfs_backref_cache
authorJosef Bacik <josef@toxicpanda.com>
Thu, 3 Oct 2024 15:43:12 +0000 (11:43 -0400)
committerDavid Sterba <dsterba@suse.com>
Mon, 13 Jan 2025 13:53:15 +0000 (14:53 +0100)
We don't ever look at this list, remove it.

Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/backref.c
fs/btrfs/backref.h
fs/btrfs/relocation.c

index 597d1d5f44ec557560b4ea813c7825fe3703c820..6d9f39c1d89c71dcf85bd053d8896ed286ac28b5 100644 (file)
@@ -3022,7 +3022,6 @@ void btrfs_backref_init_cache(struct btrfs_fs_info *fs_info,
        cache->rb_root = RB_ROOT;
        for (i = 0; i < BTRFS_MAX_LEVEL; i++)
                INIT_LIST_HEAD(&cache->pending[i]);
-       INIT_LIST_HEAD(&cache->detached);
        INIT_LIST_HEAD(&cache->pending_edge);
        INIT_LIST_HEAD(&cache->useless_node);
        cache->fs_info = fs_info;
@@ -3159,7 +3158,6 @@ void btrfs_backref_release_cache(struct btrfs_backref_cache *cache)
 
        ASSERT(list_empty(&cache->pending_edge));
        ASSERT(list_empty(&cache->useless_node));
-       ASSERT(list_empty(&cache->detached));
        ASSERT(!cache->nr_nodes);
        ASSERT(!cache->nr_edges);
 }
index bf47f7ad08be9e957a7e285ad5136137f1ab55ca..74e6140312747f9e4247f3e5aa0288a1595c2b63 100644 (file)
@@ -393,8 +393,6 @@ struct btrfs_backref_cache {
         * level blocks may not reflect the new location
         */
        struct list_head pending[BTRFS_MAX_LEVEL];
-       /* List of detached backref node. */
-       struct list_head detached;
 
        u64 last_trans;
 
index 0f94dea8e3290cb1afeae6b37b4710f9dd634392..cdd9a7b15a110ff28d515bee660e3231206cf1da 100644 (file)
@@ -367,7 +367,6 @@ static bool handle_useless_nodes(struct reloc_control *rc,
                 * cache to avoid unnecessary backref lookup.
                 */
                if (cur->level > 0) {
-                       list_add(&cur->list, &cache->detached);
                        cur->detached = 1;
                } else {
                        rb_erase(&cur->rb_node, &cache->rb_root);