net: stmmac: platform: Group GMAC4 compatible check
authorInochi Amaoto <inochiama@gmail.com>
Fri, 7 Mar 2025 01:16:15 +0000 (09:16 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Mar 2025 03:06:36 +0000 (19:06 -0800)
Use of_device_compatible_match to group existing compatible
check of GMAC4 device.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20250307011623.440792-3-inochiama@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

index d0e61aa1a495292a2894bd7ef5ad3194cc1b8081..4a3fe44b780d4d884e95cfb4060545022cf1f25f 100644 (file)
@@ -405,6 +405,16 @@ static int stmmac_of_get_mac_mode(struct device_node *np)
        return -ENODEV;
 }
 
+/* Compatible string array for all gmac4 devices */
+static const char * const stmmac_gmac4_compats[] = {
+       "snps,dwmac-4.00",
+       "snps,dwmac-4.10a",
+       "snps,dwmac-4.20a",
+       "snps,dwmac-5.10a",
+       "snps,dwmac-5.20",
+       NULL
+};
+
 /**
  * stmmac_probe_config_dt - parse device-tree driver parameters
  * @pdev: platform_device structure
@@ -538,11 +548,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
                plat->pmt = 1;
        }
 
-       if (of_device_is_compatible(np, "snps,dwmac-4.00") ||
-           of_device_is_compatible(np, "snps,dwmac-4.10a") ||
-           of_device_is_compatible(np, "snps,dwmac-4.20a") ||
-           of_device_is_compatible(np, "snps,dwmac-5.10a") ||
-           of_device_is_compatible(np, "snps,dwmac-5.20")) {
+       if (of_device_compatible_match(np, stmmac_gmac4_compats)) {
                plat->has_gmac4 = 1;
                plat->has_gmac = 0;
                plat->pmt = 1;