wifi: ath12k: make read-only array svc_id static const
authorColin Ian King <colin.i.king@gmail.com>
Wed, 18 Sep 2024 17:10:03 +0000 (20:10 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 19 Sep 2024 16:17:03 +0000 (19:17 +0300)
Don't populate the read-only array svc_id on the stack at run time,
instead make it static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240912144456.591494-1-colin.i.king@gmail.com
drivers/net/wireless/ath/ath12k/wmi.c

index 2cd3ff9b0164c8fae0ff95295499596c39bc1c3c..190439ad7f23dce931d2831e8c5a8d6b33201296 100644 (file)
@@ -7284,9 +7284,11 @@ static int ath12k_connect_pdev_htc_service(struct ath12k_base *ab,
                                           u32 pdev_idx)
 {
        int status;
-       u32 svc_id[] = { ATH12K_HTC_SVC_ID_WMI_CONTROL,
-                        ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC1,
-                        ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC2 };
+       static const u32 svc_id[] = {
+               ATH12K_HTC_SVC_ID_WMI_CONTROL,
+               ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC1,
+               ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC2
+       };
        struct ath12k_htc_svc_conn_req conn_req = {};
        struct ath12k_htc_svc_conn_resp conn_resp = {};