media: tegra-vde: use 'time_left' variable with wait_for_completion_interruptible_tim...
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 5 Aug 2024 21:51:20 +0000 (23:51 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 9 Aug 2024 05:56:39 +0000 (07:56 +0200)
There is a confusing pattern in the kernel to use a variable named
'timeout' to store the result of
wait_for_completion_interruptible_timeout() causing patterns like:

        timeout = wait_for_completion_interruptible_timeout(...)
        if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the
code self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/nvidia/tegra-vde/h264.c

index d8812fc06c676b7fd32fb063fbfdefbc0530f508..0e56a4331b0d70717ca8fd40be0242c74b3210fc 100644 (file)
@@ -623,14 +623,14 @@ static int tegra_vde_decode_end(struct tegra_vde *vde)
        unsigned int read_bytes, macroblocks_nb;
        struct device *dev = vde->dev;
        dma_addr_t bsev_ptr;
-       long timeout;
+       long time_left;
        int ret;
 
-       timeout = wait_for_completion_interruptible_timeout(
+       time_left = wait_for_completion_interruptible_timeout(
                        &vde->decode_completion, msecs_to_jiffies(1000));
-       if (timeout < 0) {
-               ret = timeout;
-       } else if (timeout == 0) {
+       if (time_left < 0) {
+               ret = time_left;
+       } else if (time_left == 0) {
                bsev_ptr = tegra_vde_readl(vde, vde->bsev, 0x10);
                macroblocks_nb = tegra_vde_readl(vde, vde->sxe, 0xC8) & 0x1FFF;
                read_bytes = bsev_ptr ? bsev_ptr - vde->bitstream_data_addr : 0;