hv_netvsc: Remove unnecessary round_up for recv_completion_cnt
authorHaiyang Zhang <haiyangz@microsoft.com>
Mon, 30 Mar 2020 19:29:13 +0000 (12:29 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 Mar 2020 02:43:42 +0000 (19:43 -0700)
The vzalloc_node(), already rounds the total size to whole pages, and
sizeof(u64) is smaller than sizeof(struct recv_comp_data). So
round_up of recv_completion_cnt is not necessary, and may cause extra
memory allocation.

To save memory, remove this unnecessary round_up for recv_completion_cnt.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hyperv/netvsc.c

index 1b320bcf150a4ddc91204e21b3bac4a1140cad5e..ca68aa1df801d74cffa55186d766205213b74ce1 100644 (file)
@@ -388,10 +388,11 @@ static int netvsc_init_buf(struct hv_device *device,
        net_device->recv_section_size = resp->sections[0].sub_alloc_size;
        net_device->recv_section_cnt = resp->sections[0].num_sub_allocs;
 
-       /* Setup receive completion ring */
-       net_device->recv_completion_cnt
-               = round_up(net_device->recv_section_cnt + 1,
-                          PAGE_SIZE / sizeof(u64));
+       /* Setup receive completion ring.
+        * Add 1 to the recv_section_cnt because at least one entry in a
+        * ring buffer has to be empty.
+        */
+       net_device->recv_completion_cnt = net_device->recv_section_cnt + 1;
        ret = netvsc_alloc_recv_comp_ring(net_device, 0);
        if (ret)
                goto cleanup;