gpio: mpc8xxx: Fix a resources leak in the error handling path of 'mpc8xxx_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 Aug 2021 15:37:55 +0000 (17:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:28:04 +0000 (12:28 +0200)
[ Upstream commit 555bda42b0c1a5ffb72d3227c043e8afde778f1f ]

Commit 698b8eeaed72 ("gpio/mpc8xxx: change irq handler from chained to normal")
has introduced a new 'goto err;' at the very end of the function, but has
not updated the error handling path accordingly.

Add the now missing 'irq_domain_remove()' call which balances a previous
'irq_domain_create_linear() call.

Fixes: 698b8eeaed72 ("gpio/mpc8xxx: change irq handler from chained to normal")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-mpc8xxx.c

index 3c2fa44d9279b085a7cc46fffec33a60a66649b1..5b2a919a66440b928648c8916271d09027180585 100644 (file)
@@ -406,6 +406,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
 
        return 0;
 err:
+       if (mpc8xxx_gc->irq)
+               irq_domain_remove(mpc8xxx_gc->irq);
        iounmap(mpc8xxx_gc->regs);
        return ret;
 }