x86/microcode/intel: Guard against stack overflow in the loader
authorQuentin Casasnovas <quentin.casasnovas@oracle.com>
Tue, 3 Feb 2015 12:00:22 +0000 (13:00 +0100)
committerBorislav Petkov <bp@suse.de>
Thu, 19 Feb 2015 11:41:37 +0000 (12:41 +0100)
mc_saved_tmp is a static array allocated on the stack, we need to make
sure mc_saved_count stays within its bounds, otherwise we're overflowing
the stack in _save_mc(). A specially crafted microcode header could lead
to a kernel crash or potentially kernel execution.

Signed-off-by: Quentin Casasnovas <quentin.casasnovas@oracle.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Link: http://lkml.kernel.org/r/1422964824-22056-1-git-send-email-quentin.casasnovas@oracle.com
Signed-off-by: Borislav Petkov <bp@suse.de>
arch/x86/kernel/cpu/microcode/intel_early.c

index ec9df6f9cd47b35e7f4d6059eb094f922420c5cf..5e109a31f62bb0168f704bd04d725b8ff580df6e 100644 (file)
@@ -321,7 +321,7 @@ get_matching_model_microcode(int cpu, unsigned long start,
        unsigned int mc_saved_count = mc_saved_data->mc_saved_count;
        int i;
 
-       while (leftover) {
+       while (leftover && mc_saved_count < ARRAY_SIZE(mc_saved_tmp)) {
                mc_header = (struct microcode_header_intel *)ucode_ptr;
 
                mc_size = get_totalsize(mc_header);