ASoC: pcm: perform power-down delay checks a bit faster
authorDragan Simic <dsimic@manjaro.org>
Tue, 9 Apr 2024 17:56:36 +0000 (19:56 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 9 Apr 2024 19:08:07 +0000 (20:08 +0100)
When checking whether the power-down delay should be ignored for a specific
PCM runtime, there's no need to keep going through all DAI link components
after any of them is found to be configured to use the power-down delay.

While there, fix a small typo in one of the comment blocks.

Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Link: https://msgid.link/r/90ae761a5b99640ece48363a7099ac2cf402bd37.1712684592.git.dsimic@manjaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 77ee103b7cd1a901f495a357f331d77e7c9adddd..b0e1bd7f588ba7857a56fa905858333d333d83a0 100644 (file)
@@ -315,23 +315,24 @@ EXPORT_SYMBOL_GPL(snd_soc_runtime_action);
  * @rtd: The ASoC PCM runtime that should be checked.
  *
  * This function checks whether the power down delay should be ignored for a
- * specific PCM runtime. Returns true if the delay is 0, if it the DAI link has
+ * specific PCM runtime. Returns true if the delay is 0, if the DAI link has
  * been configured to ignore the delay, or if none of the components benefits
  * from having the delay.
  */
 bool snd_soc_runtime_ignore_pmdown_time(struct snd_soc_pcm_runtime *rtd)
 {
        struct snd_soc_component *component;
-       bool ignore = true;
        int i;
 
        if (!rtd->pmdown_time || rtd->dai_link->ignore_pmdown_time)
                return true;
 
        for_each_rtd_components(rtd, i, component)
-               ignore &= !component->driver->use_pmdown_time;
+               if (component->driver->use_pmdown_time)
+                       /* No need to go through all components */
+                       return false;
 
-       return ignore;
+       return true;
 }
 
 /**