staging: vt6656: vnt_vt3184_init remove stack copy to array.
authorMalcolm Priestley <tvboxspy@gmail.com>
Sat, 29 Feb 2020 20:37:40 +0000 (20:37 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Mar 2020 06:52:32 +0000 (07:52 +0100)
use u8 pointer addr directly and remove stack array.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Link: https://lore.kernel.org/r/49f34764-c90c-8c5f-b4f2-a3668b13e519@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/baseband.c

index 48a624bf00c021b95c4982c0642ff0bc6f0d5c5c..74b620b4261e77b2b59f6a10e4c925a561a9bb0d 100644 (file)
@@ -367,7 +367,6 @@ int vnt_vt3184_init(struct vnt_private *priv)
        int ret = 0;
        u16 length;
        u8 *addr;
-       u8 array[256];
        u8 data;
 
        ret = vnt_control_in(priv, MESSAGE_TYPE_READ, 0, MESSAGE_REQUEST_EEPROM,
@@ -437,10 +436,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
                goto end;
        }
 
-       memcpy(array, addr, length);
-
        ret = vnt_control_out_blocks(priv, VNT_REG_BLOCK_SIZE,
-                                    MESSAGE_REQUEST_BBREG, length, array);
+                                    MESSAGE_REQUEST_BBREG, length, addr);
        if (ret)
                goto end;