projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
646be03
)
rds: rds_rm_zerocopy_callback() use list_first_entry()
author
Pietro Borrello
<borrello@diag.uniroma1.it>
Tue, 7 Feb 2023 18:26:34 +0000
(18:26 +0000)
committer
Paolo Abeni
<pabeni@redhat.com>
Thu, 9 Feb 2023 09:37:26 +0000
(10:37 +0100)
rds_rm_zerocopy_callback() uses list_entry() on the head of a list
causing a type confusion.
Use list_first_entry() to actually access the first element of the
rs_zcookie_queue list.
Fixes:
9426bbc6de99
("rds: use list structure to track information for zerocopy completion notification")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link:
https://lore.kernel.org/r/20230202-rds-zerocopy-v3-1-83b0df974f9a@diag.uniroma1.it
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/rds/message.c
patch
|
blob
|
blame
|
history
diff --git
a/net/rds/message.c
b/net/rds/message.c
index b47e4f0a163934b561cecc5fc89711b0ecfee2ce..c19c9356122782868748ca8b12ee4914d30a8433 100644
(file)
--- a/
net/rds/message.c
+++ b/
net/rds/message.c
@@
-104,9
+104,9
@@
static void rds_rm_zerocopy_callback(struct rds_sock *rs,
spin_lock_irqsave(&q->lock, flags);
head = &q->zcookie_head;
if (!list_empty(head)) {
- info = list_entry(head, struct rds_msg_zcopy_info,
- rs_zcookie_next);
- if (
info &&
rds_zcookie_add(info, cookie)) {
+ info = list_
first_
entry(head, struct rds_msg_zcopy_info,
+
rs_zcookie_next);
+ if (rds_zcookie_add(info, cookie)) {
spin_unlock_irqrestore(&q->lock, flags);
kfree(rds_info_from_znotifier(znotif));
/* caller invokes rds_wake_sk_sleep() */